Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(MLP-13) : Update journey display criterion to include desktop, rename mobileUserAgent to getPlatformByUserAgent #960

Merged
merged 3 commits into from
Dec 11, 2023

Conversation

JagadeeshKaricherla-branch
Copy link
Contributor

Description

  • Include desktop in shouldDisplayJourney
  • rename mobileUserAgent to getPlatformByUserAgent and include definition for desktop
  • add unit tests for above

Fixes # (issue) : MLP-13

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Unit test
  • Integration test

JS Budget Check

Please mention the size in kb before abd after this PR

Files Before After
dist/build.js.
dist/build.min.js

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Mentions:

List the person or team responsible for reviewing proposed changes.

cc @BranchMetrics/saas-sdk-devs for visibility.

…add support for desktop journey

rename mobileUserAgent to getPlatformByUserAgent and add support for desktop journey
Copy link
Contributor

github-actions bot commented Nov 29, 2023

Test Results

123 tests   116 ✔️  46s ⏱️
    1 suites      7 💤
    1 files        0

Results for commit 7ff34d0.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Nov 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (master@e8b2db5). Click here to learn what that means.

❗ Current head 6fc5bbd differs from pull request most recent head 7ff34d0. Consider uploading reports for the commit 7ff34d0 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #960   +/-   ##
=========================================
  Coverage          ?   25.15%           
=========================================
  Files             ?       15           
  Lines             ?     2326           
  Branches          ?        0           
=========================================
  Hits              ?      585           
  Misses            ?     1741           
  Partials          ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jwangler-branch jwangler-branch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done

@JagadeeshKaricherla-branch JagadeeshKaricherla-branch merged commit 1293351 into master Dec 11, 2023
5 checks passed
@JagadeeshKaricherla-branch JagadeeshKaricherla-branch deleted the feature/journey-useragent branch December 11, 2023 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants