Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK 2302 update singleton creation to dispatch once #1388

Merged
merged 7 commits into from
Apr 29, 2024
Merged

Conversation

echo-branch
Copy link
Contributor

Reference

SDK-2302

Summary

Update to modern singleton creation syntax

Motivation

Code modernization

Type Of Change

Testing Instructions

There should be no functional change

cc @BranchMetrics/saas-sdk-devs for visibility.

Copy link

codecov bot commented Apr 22, 2024

Codecov Report

Attention: Patch coverage is 90.38462% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 51.10%. Comparing base (4842da0) to head (1836823).
Report is 6 commits behind head on master.

Files Patch % Lines
Sources/BranchSDK/BNCKeyChain.m 66.66% 2 Missing and 1 partial ⚠️
Sources/BranchSDK/BNCEventUtils.m 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1388      +/-   ##
==========================================
+ Coverage   51.03%   51.10%   +0.06%     
==========================================
  Files          66       66              
  Lines       10158    10158              
  Branches     3724     3724              
==========================================
+ Hits         5184     5191       +7     
+ Misses       4716     4707       -9     
- Partials      258      260       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@echo-branch echo-branch merged commit 4800c88 into master Apr 29, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants