SDK-2182 port layout changes for tuist spm #1349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…testing-and-validation # Conflicts: # Sources/BranchSDK/Private/BNCFieldDefines.h
1 task
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1349 +/- ##
==========================================
+ Coverage 50.94% 51.02% +0.07%
==========================================
Files 67 66 -1
Lines 10130 10143 +13
Branches 3798 3722 -76
==========================================
+ Hits 5161 5175 +14
+ Misses 4704 4702 -2
- Partials 265 266 +1 ☔ View full report in Codecov by Sentry. |
nsingh-branch
approved these changes
Feb 14, 2024
# Conflicts: # Branch-TestBed/Branch-TestBed.xcodeproj/project.pbxproj # BranchSDK.xcodeproj/project.pbxproj # Sources/BranchSDK/BNCLog.m # Sources/BranchSDK/BNCServerInterface.m # Sources/BranchSDK/Branch.m # Sources/BranchSDK/BranchLogger.h # Sources/BranchSDK/BranchLogger.m # Sources/BranchSDK/Private/BNCLog.h
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference
SDK-2182
This PR ports over changes that were already released for Tuist SPM on the spm repo. Also includes additional changes to fix integration with cocoapods and carthage.
Summary
Source code layout has been changed to allow non-Xcode SPM to integrate the Branch SDK. This unblocks tuist users.
Updated cocoapods and carthage builds to account for the new layout.
Also includes a bugfix for an earlier unit test changes around BNCURLFilter, this has not shipped yet.
Motivation
Fix compatibility with SPM when not building from within Xcode.
Type Of Change
Testing Instructions
Confirm SPM can install and build the Branch SDK.
Confirm Cocoapods can install and build the Branch SDK.
Confirm Carthage can install and build the Branch SDK.
Confirm manually built xcframeworks are valid.
Confirm Branch skiplist version is properly stored.
cc @BranchMetrics/saas-sdk-devs for visibility.