Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(WIP) - SDK 2223 DMA Consent Params Implementation #1345

Merged
merged 6 commits into from
Feb 15, 2024

Conversation

NidhiDixit09
Copy link
Collaborator

Reference

SDK-2223 -- Design and implement key/values to represent consent param

Summary

  • Added following API in Branch Class.
    + (void) setDMAParamsForEEA:(BOOL) eeaRegion AdPersonalizationConsent:(BOOL) adPersonalizationConsent AdUserDataUsageConsent:(BOOL) adUserDataUsageConsent;
  • Branch SDK will save DMA Compliance Parameters, set by developer using above API, and will send to server with install, open and event requests. BranchPreferenceHelper class is updated to store and read these params.
  • Added unit test for testing above API

Motivation

Support new params added in Google Conversion API for DMA Compliance.

Type Of Change

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Testing Instructions

  • All unit tests should pass.
  • Call API setDMAParamsForEEA and check
    -- SDK is sending value of eeaRegion, with every /v1/install , /v1/open, /v2/event , v1/pageview request.
    -- SDKis sending value of adPersonalizationConsent / adUserDataUsageConsent with every /v1/install , /v1/open, /v2/event , v1/pageview request only if -
    - eeaRegion is true OR
    - eeaRegion is false and adPersonalizationConsent / adUserDataUsageConsent is also set to false
    Ref : https://www.notion.so/brancheng/Google-DMA-Compliance-c19ed28d2ea74b2b9fa4d2d77f8cdcbe

cc @BranchMetrics/saas-sdk-devs for visibility.

Copy link

codecov bot commented Feb 14, 2024

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (bf6e9ee) 50.73% compared to head (6a61813) 50.98%.
Report is 2 commits behind head on master.

❗ Current head 6a61813 differs from pull request most recent head ecb5e3b. Consider uploading reports for the commit ecb5e3b to get more accurate results

Files Patch % Lines
BranchSDK/BNCPreferenceHelper.m 86.95% 0 Missing and 6 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1345      +/-   ##
==========================================
+ Coverage   50.73%   50.98%   +0.24%     
==========================================
  Files          68       68              
  Lines       10081    10144      +63     
  Branches     3864     3884      +20     
==========================================
+ Hits         5115     5172      +57     
  Misses       4708     4708              
- Partials      258      264       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

BranchSDK/Branch.m Outdated Show resolved Hide resolved
@NidhiDixit09 NidhiDixit09 merged commit 8eb3280 into master Feb 15, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants