Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add public API to route requests to EU endpoints #1306

Merged
merged 3 commits into from
Oct 10, 2023

Conversation

echo-branch
Copy link
Contributor

Reference

SDK-2045 Add public API to route requests to EU endpoints

Summary

Add public API to route requests to EU endpoints

Motivation

Currently, clients must edit source code to use EU endpoints. This change adds a simpler public API to send requests to EU endpoints.

Type Of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Testing Instructions

Confirm setting this prior to initSession results in calls going the EU endpoint. Note apps that are not enabled for the EU endpoints, will see server errors.

cc @BranchMetrics/saas-sdk-devs for visibility.

@nsingh-branch
Copy link
Contributor

I seem to still be getting api3.branch.io no matter where i use the method.

Copy link
Collaborator

@NidhiDixit09 NidhiDixit09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

Merging #1306 (2ef5da1) into master (45f58a0) will decrease coverage by 0.02%.
Report is 3 commits behind head on master.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #1306      +/-   ##
==========================================
- Coverage   50.67%   50.65%   -0.02%     
==========================================
  Files          68       68              
  Lines       10106    10109       +3     
  Branches     3889     3890       +1     
==========================================
  Hits         5121     5121              
- Misses       4742     4745       +3     
  Partials      243      243              
Files Coverage Δ
BranchSDK/Branch.m 37.53% <0.00%> (-0.07%) ⬇️

@echo-branch echo-branch merged commit 5e937d5 into master Oct 10, 2023
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants