Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK-2124 privacy manifest #1304

Merged
merged 2 commits into from
Oct 5, 2023
Merged

SDK-2124 privacy manifest #1304

merged 2 commits into from
Oct 5, 2023

Conversation

echo-branch
Copy link
Contributor

@echo-branch echo-branch commented Oct 4, 2023

Reference

SDK-2124 add first version of privacy manifest

Summary

Added privacy manifest and updated SDK version number.

Motivation

Add support for privacy manifests

Type Of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Testing Instructions

The following integration methods should include a privacy manifest, so archiving and generating an privacy report should work.

SPM
Cocoapods - requires the use_frameworks! option in the Podfile.
Framework
Carthage

cc @BranchMetrics/saas-sdk-devs for visibility.

@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

Merging #1304 (6be2382) into master (60b8a62) will increase coverage by 0.18%.
Report is 1 commits behind head on master.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1304      +/-   ##
==========================================
+ Coverage   50.48%   50.67%   +0.18%     
==========================================
  Files          68       68              
  Lines       10106    10106              
  Branches     3889     3889              
==========================================
+ Hits         5102     5121      +19     
+ Misses       4758     4742      -16     
+ Partials      246      243       -3     

see 4 files with indirect coverage changes

Copy link
Contributor

@nsingh-branch nsingh-branch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to generate the privacy report with each of the different integration methods. LGTM

@echo-branch echo-branch merged commit b9a11d5 into master Oct 5, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants