Review Comments fixes- Removed @synchronize lock and changes true/fal…

…se to YES/NO
BranchMetrics · Feb 14, 2024 · ecb5e3b · ecb5e3b
1 parent 6a61813
commit ecb5e3b
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 10 deletions.
diff --git a/BranchSDK/BNCPreferenceHelper.m b/BranchSDK/BNCPreferenceHelper.m
@@ -801,16 +801,16 @@ - (void) setInvokeRegisterApp:(BOOL)invoke {
 - (BOOL) eeaRegionInitialized {
     @synchronized(self) {
         if([self readObjectFromDefaults:BRANCH_PREFS_KEY_DMA_EEA])
-            return true;
-        return false;
+            return YES;
+        return NO;
     }
 }
 
 - (BOOL) eeaRegion {
     @synchronized(self) {
         NSNumber *b = (id) [self readObjectFromDefaults:BRANCH_PREFS_KEY_DMA_EEA];
         if ([b isKindOfClass:NSNumber.class]) return [b boolValue];
-        return false;
+        return NO;
     }
 }
 
@@ -825,7 +825,7 @@ - (BOOL) adPersonalizationConsent {
     @synchronized(self) {
         NSNumber *b = (id) [self readObjectFromDefaults:BRANCH_PREFS_KEY_DMA_AD_PERSONALIZATION];
         if ([b isKindOfClass:NSNumber.class]) return [b boolValue];
-        return false;
+        return NO;
     }
 }
 
@@ -840,7 +840,7 @@ - (BOOL) adUserDataUsageConsent {
     @synchronized(self) {
         NSNumber *b = (id) [self readObjectFromDefaults:BRANCH_PREFS_KEY_DMA_AD_USER_DATA];
         if ([b isKindOfClass:NSNumber.class]) return [b boolValue];
-        return false;
+        return NO;
     }
 }
 

diff --git a/BranchSDK/Branch.m b/BranchSDK/Branch.m
@@ -541,11 +541,9 @@ + (void)setReferrerGbraidValidityWindow:(NSTimeInterval)validityWindow{
 }
 
 + (void) setDMAParamsForEEA:(BOOL)eeaRegion AdPersonalizationConsent:(BOOL)adPersonalizationConsent AdUserDataUsageConsent:(BOOL)adUserDataUsageConsent{
-    @synchronized(self) {
-        [BNCPreferenceHelper sharedInstance].eeaRegion = eeaRegion;
-        [BNCPreferenceHelper sharedInstance].adPersonalizationConsent = adPersonalizationConsent;
-        [BNCPreferenceHelper sharedInstance].adUserDataUsageConsent = adUserDataUsageConsent;
-    }
+    [BNCPreferenceHelper sharedInstance].eeaRegion = eeaRegion;
+    [BNCPreferenceHelper sharedInstance].adPersonalizationConsent = adPersonalizationConsent;
+    [BNCPreferenceHelper sharedInstance].adUserDataUsageConsent = adUserDataUsageConsent;
 }
 
 #pragma mark - InitSession Permutation methods