Merge pull request #1325 from BranchMetrics/SDK-1711-fix-old-linker-i…

…ssue-for-iOS-12

SDK-1711 fix crash on iOS 12 when using the pre-built xcframework

BranchSDK.xcodeproj/project.pbxproj

@@ -1954,6 +1954,10 @@
 					"@loader_path/Frameworks",
 				);
 				MARKETING_VERSION = 3.0.1;
+				OTHER_LDFLAGS = (
+					"-weak_framework",
+					LinkPresentation,
+				);
 				PRODUCT_BUNDLE_IDENTIFIER = io.branch.BranchSDK;
 				PRODUCT_NAME = "$(TARGET_NAME:c99extidentifier)";
 				PROVISIONING_PROFILE_SPECIFIER = "";
@@ -1985,6 +1989,10 @@
 					"@loader_path/Frameworks",
 				);
 				MARKETING_VERSION = 3.0.1;
+				OTHER_LDFLAGS = (
+					"-weak_framework",
+					LinkPresentation,
+				);
 				PRODUCT_BUNDLE_IDENTIFIER = io.branch.BranchSDK;
 				PRODUCT_NAME = "$(TARGET_NAME:c99extidentifier)";
 				PROVISIONING_PROFILE_SPECIFIER = "";
@@ -2187,6 +2195,10 @@
 				);
 				MACH_O_TYPE = staticlib;
 				MARKETING_VERSION = 3.0.1;
+				OTHER_LDFLAGS = (
+					"-weak_framework",
+					LinkPresentation,
+				);
 				PRODUCT_BUNDLE_IDENTIFIER = io.branch.BranchSDK;
 				PRODUCT_MODULE_NAME = BranchSDK;
 				PRODUCT_NAME = BranchSDK;
@@ -2222,6 +2234,10 @@
 				);
 				MACH_O_TYPE = staticlib;
 				MARKETING_VERSION = 3.0.1;
+				OTHER_LDFLAGS = (
+					"-weak_framework",
+					LinkPresentation,
+				);
 				PRODUCT_BUNDLE_IDENTIFIER = io.branch.BranchSDK;
 				PRODUCT_MODULE_NAME = BranchSDK;
 				PRODUCT_NAME = BranchSDK;
@@ -2255,6 +2271,10 @@
 					"@loader_path/Frameworks",
 				);
 				MARKETING_VERSION = 3.0.1;
+				OTHER_LDFLAGS = (
+					"-weak_framework",
+					LinkPresentation,
+				);
 				PRODUCT_BUNDLE_IDENTIFIER = io.branch.BranchSDK;
 				PRODUCT_NAME = BranchSDK;
 				PROVISIONING_PROFILE_SPECIFIER = "";
@@ -2286,6 +2306,10 @@
 					"@loader_path/Frameworks",
 				);
 				MARKETING_VERSION = 3.0.1;
+				OTHER_LDFLAGS = (
+					"-weak_framework",
+					LinkPresentation,
+				);
 				PRODUCT_BUNDLE_IDENTIFIER = io.branch.BranchSDK;
 				PRODUCT_NAME = BranchSDK;
 				PROVISIONING_PROFILE_SPECIFIER = "";

ChangeLog.md

@@ -24,6 +24,11 @@ v.3.0.0
     - pre-iOS 10 locale support
     - Device carrier. This was used for fraud analysis, but is no longer available on new iOS versions.
 
+v.2.3.1
+This version is for a hotfix on Xamarin, it will not ship as a general iOS release.
+
+- SDK-2179 Fix LinkPresentation linker issue causing crash on Xamarin when run on iOS 12 or iOS 13. Thanks @LeadAssimilator.
+
 v.2.2.1
 
 Branch iOS SDK 2.2.1 adds parameter for current SKAN 4.0 Window in /v1/open and /v2/event requests.

scripts/version.sh

@@ -107,7 +107,7 @@ if [[ $update ]]; then
     sed -i '' -e "/^[[:space:]]*s\.version/ {s/\".*\"/\"$version\"/; }" ../BranchSDK.podspec
 
     # Update framework version
-    sed -ie 's/MARKETING_VERSION = '"$prev_version"'/MARKETING_VERSION = '"$version"'/g' ../BranchSDK.xcodeproj/project.pbxproj
+    sed -i '' -e 's/MARKETING_VERSION = '"$prev_version"'/MARKETING_VERSION = '"$version"'/g' ../BranchSDK.xcodeproj/project.pbxproj
 fi