Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix build ios project name #640

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Leo1305Pineda
Copy link

There is an error building the project in ios.
the cause is that if in the config.xml the project name tag is placed like this.
image
the following error is generated
image
This is due to the characters new line \ n, return \ r and spaces before and after the project name.
Partial solution: not use these characters in the name del projecto.
Definitive solution with regular expressions: replace (/ [\ r \ n] + / gm, '') .replace (/ (^ [\ s] + | [\ s] + $) / g, '')

@codinronan
Copy link
Contributor

Thanks @Leo1305Pineda this looks like a good change, we'll make sure it gets in.

@echo-branch
Copy link
Contributor

@adrianyg7
Was this included in another PR?

@adrianyg7
Copy link
Contributor

@echo-branch no
@Leo1305Pineda how did you get a config.xml file containing new-lines/return/spaces on name tag? Neither Cordova, PhoneGap or Ionic cli will produce such thing.

@Leo1305Pineda
Copy link
Author

Leo1305Pineda commented Jul 10, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants