Skip to content
This repository has been archived by the owner on Apr 16, 2022. It is now read-only.

Replaced lxml library with standard lib xml library #89

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

jacobamarshall
Copy link

Replaced lxml library with standard lib xml library
Reformatted code with Black (https://pypi.org/project/black/)

Description

Updated imports and replaced all Element.getparent() and Element.index()
calls with other logic to retrieve parent elements

Motivation and Context

lxml poses challenges when using this library in aws lambda environments,
and standard lib is preferable when available

How Has This Been Tested?

All tests ran successfully with %python -m unittest discover

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Replaced lxml library with standard lib xml library
Reformatted code with Black
ignore files in venv
ignore .idea
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant