This repository has been archived by the owner on Apr 16, 2022. It is now read-only.
Added support for "\@" formatting code for dates. #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This supports only dates at this moment.
Even if user won't specify '\*', or would strip code to bare minimum i.e. "MERGEFIELD foo" (which is valid according to Word), it would still evaluate with default formats. This default format is dependent on locale settings which seems to be consistent with what Word is doing.
Formatting "None" (called from MailMerge.write) would cause errors. In such cases it should always evaluate to '' (empty string), and any other type that is not a date or time would evaluate to string representation.
|
I think this looks like a nice addition. I haven't gotten any use for this library myself, and haven't touched the code in a while. With that in mind, I think the code looks good. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change implements very simple
\@formatting code. Examples:yyyyyyyYYYYYYYMMMMMMMdddddddThe biggest change is that you can now pass custom types, and let the user do the formatting. I.e. pass
datetime.datetimeand expect user to add formatting code.There is also default behaviour for certain types which tries to be consistent with Word - i.e. datetime by default would be formatted according to locales etc.
This is still a POC - what do you think on this approach?
Motivation and Context
Let the user do the formatting according to his needs. Your app should be able to pass
datetime.datetimeobjects and expect user to format it according to his needs. It was reported before at least in #13.How Has This Been Tested?
Added unit tests for eval stage.
Types of changes
Checklist: