Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FilterError iterator #136

Merged
merged 1 commit into from
Aug 9, 2024
Merged

Add FilterError iterator #136

merged 1 commit into from
Aug 9, 2024

Conversation

BooleanCat
Copy link
Owner

@BooleanCat BooleanCat commented Aug 9, 2024

Please provide a brief description of the change.

Allow for filtering iterators where the predicate can return an error.

Which issue does this change relate to?

#135

Contribution checklist.

  • I have read and understood the CONTRIBUTING guidelines
  • All commits in my PR conform to the commit hygiene section
  • I have added relevant tests
  • I have not added any dependencies

Additional context

Copy link

codecov bot commented Aug 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (7a53055) to head (0d45519).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #136   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           32        32           
  Lines          403       423   +20     
=========================================
+ Hits           403       423   +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danail-branekov
Copy link

Looks like precisely how I imagined it, @BooleanCat :)

@BooleanCat BooleanCat marked this pull request as ready for review August 9, 2024 11:43
@BooleanCat BooleanCat merged commit 10d36e7 into main Aug 9, 2024
6 checks passed
@BooleanCat BooleanCat deleted the filtererror branch August 9, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants