Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Django 5 #158

Merged
merged 1 commit into from
Dec 12, 2023
Merged

Add support for Django 5 #158

merged 1 commit into from
Dec 12, 2023

Conversation

scastlara
Copy link
Contributor

@scastlara scastlara commented Dec 11, 2023

Django 5.0 removed the alias to datetime.timezone.utc.

See: https://docs.djangoproject.com/en/5.0/releases/5.0/#features-removed-in-5-0

You would get this error when viewing the admin:

image

closes #159

@scastlara
Copy link
Contributor Author

scastlara commented Dec 12, 2023

Shall we exclude python < 3.10 for Django 5 in the test matrix?

https://docs.djangoproject.com/en/5.0/releases/5.0/#python-compatibility

Django 5.0 supports Python 3.10, 3.11, and 3.12

@amureki
Copy link
Collaborator

amureki commented Dec 12, 2023

@scastlara hey Sergio!
Thanks for the issue and PR solving it right away!

Yes, I think this is a way to go. Test matrix should reflect official Django compatibility requirements.

@amureki amureki merged commit aa74f17 into Bogdanp:master Dec 12, 2023
19 checks passed
@scastlara scastlara deleted the django-5 branch December 12, 2023 12:36
@amureki
Copy link
Collaborator

amureki commented Dec 12, 2023

Thanks again!

This is released under 0.11.6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Admin does not work with Django 5
2 participants