New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test qc pr #17

Merged

zsigmas merged 12 commits into main from fix_test_qc_pr

Jun 5, 2024

Contributor

zsigmas commented Jun 4, 2024

No description provided.

zsigmas and others added 5 commits

June 4, 2024 14:06


          fix test so they can run on the installed package

f76b0aa

- Includes qc doc
  - Only used for dv.templates other packages must contain their own set of scripts
- Includes the testing badge
fix tests

include qc doc

add badge

style & lint


          Merge pull request #16 from zsigmas/fix_test_qc_pr

29d2b62

fix test so they can run on the installed package


          run actions in the same way as packages will

4d2e111


          remove call conditions in test.yml

2bd4bbd


          fix name typo

zsigmas marked this pull request as ready for review

June 4, 2024 13:26

zsigmas requested review from sorinvoicu and mattkorb

June 4, 2024 13:26

sorinvoicu reviewed

View reviewed changes

.github/workflows/shared_ci.yml Show resolved Hide resolved

sorinvoicu reviewed

View reviewed changes

.github/workflows/test.yml Outdated Show resolved Hide resolved

sorinvoicu reviewed

View reviewed changes

inst/validation/utils-validation.R Show resolved Hide resolved

sorinvoicu reviewed

View reviewed changes

.github/workflows/check.yml Outdated Show resolved Hide resolved

sorinvoicu reviewed

View reviewed changes

inst/validation/specs.R Show resolved Hide resolved

sorinvoicu reviewed

View reviewed changes

inst/validation/utils-validation.R Show resolved Hide resolved

sorinvoicu reviewed

View reviewed changes

.github/workflows/test.yml Outdated Show resolved Hide resolved

sorinvoicu reviewed

View reviewed changes

inst/validation/val_report_child.Rmd Show resolved Hide resolved

zsigmas added 4 commits

June 4, 2024 22:20


          add test.yml to workflows.md


          use shell instead of explicit call to Rscript

bbe3b0e


          remove explicit GITHUB_PAT

c550c58


          rename test.R to test_qc_pkg.R

130610b

Contributor Author

zsigmas commented Jun 4, 2024

closes #15

Contributor Author

zsigmas commented Jun 4, 2024

I have created #18 to cover the centralized qc scripts in a later PR

zsigmas requested a review from sorinvoicu

June 4, 2024 20:48

This was referenced Jun 5, 2024

QC report review #19

Closed

consider including and consuming the qc documentation from dv.templates #20

Closed

sorinvoicu reviewed

View reviewed changes

.github/workflows/test.yml Outdated Show resolved Hide resolved


          refactor test.yml

bcb6e10

- only clone required directories
- move ref branch to variable

zsigmas requested a review from sorinvoicu

June 5, 2024 08:13

sorinvoicu reviewed

View reviewed changes

.github/workflows/test.yml Outdated Show resolved Hide resolved


          move template repo to var in test.yml

ee651aa


          fix typo

sorinvoicu self-assigned this

sorinvoicu approved these changes

View reviewed changes

zsigmas merged commit 20eb87f into main

7 checks passed

zsigmas deleted the fix_test_qc_pr branch

June 5, 2024 08:58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet