Skip to content

Commit

Permalink
include qc report in a separate step
Browse files Browse the repository at this point in the history
include PAT

checkout templates
  • Loading branch information
zsigmas committed Jun 3, 2024
1 parent 0b98266 commit f72298a
Show file tree
Hide file tree
Showing 8 changed files with 215 additions and 16 deletions.
10 changes: 6 additions & 4 deletions .github/workflows/check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,27 +16,29 @@ on:
workflow_call:

concurrency:
group: check-test-${{ github.event.pull_request.number || github.ref }}
group: check-${{ github.event.pull_request.number || github.ref }}
cancel-in-progress: true

jobs:
check-test:
check:
name: ${{ vars.CI_IMAGE }}
runs-on: ubuntu-latest
container:
image: ${{ vars.CI_IMAGE }}
env:
GITHUB_PAT: ${{ secrets.GITHUB_TOKEN }}

steps:
- name: Checkout project ⬇️
uses: actions/checkout@v4

- name: Install package dependencies 📄
uses: boehringer-ingelheim/dv.templates/.github/actions/dependencies@main
uses: zsigmas/dv.templates/.github/actions/dependencies@include_qc_separate_steps

- name: Check 📦
run: |
options(crayon.enabled = TRUE)
rcmdcheck::rcmdcheck(error_on = "error")
rcmdcheck::rcmdcheck(error_on = "error", args = "--no-tests")
shell: Rscript {0}


6 changes: 4 additions & 2 deletions .github/workflows/lintr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,17 +31,19 @@ jobs:
runs-on: ubuntu-latest
container:
image: ${{ vars.CI_IMAGE }}
env:
GITHUB_PAT: ${{ secrets.GITHUB_TOKEN }}

steps:
- name: Checkout project ⬇️
uses: actions/checkout@v4

- name: Install package dependencies 📄
uses: boehringer-ingelheim/dv.templates/.github/actions/dependencies@main
uses: zsigmas/dv.templates/.github/actions/dependencies@include_qc_separate_steps

- name: Import .lintr
run: |
wget -O .lintr https://raw.githubusercontent.com/Boehringer-Ingelheim/dv.templates/main/.lintr
wget -O .lintr https://raw.githubusercontent.com/zsigmas/dv.templates/main/.lintr
- name: Lintr 🔍
run: lintr::lint_package()
Expand Down
10 changes: 9 additions & 1 deletion .github/workflows/pkgdown.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,13 +25,21 @@ jobs:
runs-on: ubuntu-latest
container:
image: ${{ vars.CI_IMAGE }}
env:
GITHUB_PAT: ${{ secrets.GITHUB_TOKEN }}

steps:
- name: Checkout project ⬇️
uses: actions/checkout@v4

- name: Install package dependencies 📄
uses: boehringer-ingelheim/dv.templates/.github/actions/dependencies@main
uses: zsigmas/dv.templates/.github/actions/dependencies@include_qc_separate_steps

- name: Get validation results
uses: actions/download-artifact@v4
with:
name: val_results
path: inst/validation/results

- name: Build site 🔧
run: pkgdown::build_site()
Expand Down
4 changes: 3 additions & 1 deletion .github/workflows/roxygen.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,13 +25,15 @@ jobs:
runs-on: ubuntu-latest
container:
image: ${{ vars.CI_IMAGE }}
env:
GITHUB_PAT: ${{ secrets.GITHUB_TOKEN }}

steps:
- name: Checkout project ⬇️
uses: actions/checkout@v4

- name: Install package dependencies 📄
uses: boehringer-ingelheim/dv.templates/.github/actions/dependencies@main
uses: zsigmas/dv.templates/.github/actions/dependencies@include_qc_separate_steps

- name: Generate man pages 📄
run: |
Expand Down
19 changes: 12 additions & 7 deletions .github/workflows/shared_ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,28 +5,33 @@ on:
workflow_call:

jobs:
check-test:
check:
name: Check 📦
uses: boehringer-ingelheim/dv.templates/.github/workflows/check.yml@main
uses: zsigmas/dv.templates/.github/workflows/check.yml@include_qc_separate_steps

test:
name: Test 📦
uses: zsigmas/dv.templates/.github/workflows/test.yml@include_qc_separate_steps

lintr:
name: Lintr 🔍
uses: boehringer-ingelheim/dv.templates/.github/workflows/lintr.yml@main
uses: zsigmas/dv.templates/.github/workflows/lintr.yml@include_qc_separate_steps
with:
lintr_error_on_lint: true

gitleaks:
name: Gitleaks 🌧️
uses: boehringer-ingelheim/dv.templates/.github/workflows/gitleaks.yml@main
uses: zsigmas/dv.templates/.github/workflows/gitleaks.yml@include_qc_separate_steps

roxygen:
name: Roxygen 📄
uses: boehringer-ingelheim/dv.templates/.github/workflows/roxygen.yml@main
uses: zsigmas/dv.templates/.github/workflows/roxygen.yml@include_qc_separate_steps

pkgdown:
name: Pkgdown 📖
uses: boehringer-ingelheim/dv.templates/.github/workflows/pkgdown.yml@main
uses: zsigmas/dv.templates/.github/workflows/pkgdown.yml@include_qc_separate_steps
needs: test

styler:
name: Styler 🌐
uses: boehringer-ingelheim/dv.templates/.github/workflows/styler.yml@main
uses: zsigmas/dv.templates/.github/workflows/styler.yml@include_qc_separate_steps
4 changes: 3 additions & 1 deletion .github/workflows/styler.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,13 +25,15 @@ jobs:
runs-on: ubuntu-latest
container:
image: ${{ vars.CI_IMAGE }}
env:
GITHUB_PAT: ${{ secrets.GITHUB_TOKEN }}

steps:
- name: Checkout project ⬇️
uses: actions/checkout@v4

- name: Install package dependencies 📄
uses: boehringer-ingelheim/dv.templates/.github/actions/dependencies@main
uses: zsigmas/dv.templates/.github/actions/dependencies@include_qc_separate_steps

- name: Run styler 🦄
run: |
Expand Down
52 changes: 52 additions & 0 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,52 @@
---
name: Test 📦

on:
pull_request:
types:
- opened
- synchronize
- reopened
- ready_for_review
branches:
- main
push:
branches:
- main
workflow_call:

concurrency:
group: test-${{ github.event.pull_request.number || github.ref }}
cancel-in-progress: true

jobs:
test:
name: ${{ vars.CI_IMAGE }}
runs-on: ubuntu-latest
container:
image: ${{ vars.CI_IMAGE }}
env:
GITHUB_PAT: ${{ secrets.GITHUB_TOKEN }}

steps:
- name: Checkout project ⬇️
uses: actions/checkout@v4

- name: Checkout Repo Templates
uses: actions/checkout@v4
with:
ref: include_qc_separate_steps
repository: zsigmas/dv.templates
path: templates

- name: Install package dependencies 📄
uses: zsigmas/dv.templates/.github/actions/dependencies@include_qc_separate_steps

- name: Test 📦
run: Rscript templates/scripts/test.R

- name: Archive validation results
uses: actions/upload-artifact@v4
with:
name: val_results
path: inst/validation/results
126 changes: 126 additions & 0 deletions scripts/test.R
Original file line number Diff line number Diff line change
@@ -0,0 +1,126 @@
#! /usr/local/bin/Rscript

success <- c(
test = FALSE,
valdoc = FALSE
)

# Getting package information ----
pkg_name <- read.dcf("DESCRIPTION")[1, "Package"]
pkg_version <- read.dcf("DESCRIPTION")[1, "Version"]

# Building ----

message("############################")
message("###### INSTALLING (S) ######")
message("############################")

devtools::install(upgrade = FALSE, args = "--install-tests")

message("############################")
message("###### INSTALLING (F) ######")
message("############################")

# Testing ----

message("##########################")
message("###### TESTING (S) ######")
message("##########################")

reporter <- testthat::MultiReporter$new(
list(
testthat::ProgressReporter$new(),
testthat::SummaryReporter$new(file = file.path(getwd(), "tests", "test-out.xml"))
)
)

test_results <- tibble::as_tibble(
withr::with_envvar(
new = list(CI = TRUE, no_proxy = "127.0.0.1", NOT_CRAN = TRUE, TESTTHAT_CPUS = 1),
code = {
testthat::test_package(pkg_name, reporter, stop_on_failure = FALSE)
}
)
)

success[["test"]] <- sum(test_results[["failed"]]) == 0

message("##########################")
message("###### TESTING (F) ######")
message("##########################")

# Validation ----

message("#######################################")
message("###### RENDERING VALIDATION (S) ######")
message("#######################################")

success[["valdoc"]] <- local({
# This is evaluated inside a local because, otherwise, all the variables created in the chunks of the rendered
# document leak into the environment

validation_root <- "./inst/validation"
validation_report_rmd <- file.path(validation_root, "val_report.Rmd")
validation_report_html <- "val_report.html"
validation_results <- file.path(validation_root, "results")
val_param_rds <- file.path(validation_results, "val_param.rds")

stopifnot(dir.exists(validation_root))
stopifnot(file.exists(validation_report_rmd))

stopifnot(dir.exists(validation_results))
unlink(list.files(validation_results))

saveRDS(
list(
package = pkg_name,
tests = test_results,
version = pkg_version
),
val_param_rds
)

rmarkdown::render(
input = validation_report_rmd,
params = list(
package = pkg_name,
tests = test_results,
version = pkg_version
),
output_dir = validation_results,
output_file = validation_report_html
)

# We use one of the leaked variables, created inside the validation report to asses if the validation is succesful or not
VALIDATION_PASSED
})


message("#######################################")
message("###### RENDERING VALIDATION (F) ######")
message("#######################################")

# Exit ----
message("##############################")
message("###### BUILD RESULT (S) ######")
message("##############################")

message(paste("Was", names(success), "successful?\t", success, collapse = "\n"))

# Write GITHUB ACTIONS summary
github_summary_file <- Sys.getenv("GITHUB_STEP_SUMMARY")
summary <- "# Test Summary"
summary <- c(
summary,
purrr::imap_chr(success, ~ paste(" - ", if (.x) "\U02705" else "\U274C", "\t", .y))
)

CON <- file(github_summary_file, "a")
on.exit(close(CON))
writeLines(summary, CON)

stopifnot(all(success))

message("##############################")
message("###### BUILD RESULT (F) ######")
message("##############################")

0 comments on commit f72298a

Please sign in to comment.