Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release] rc/v0.0.2 #11

Merged
merged 11 commits into from
Dec 3, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,6 @@ on:
branches:
- main
push:
branches:
- main
- dev
workflow_dispatch:

jobs:
Expand Down
21 changes: 21 additions & 0 deletions .lintr.R
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
linters <- lintr::default_linters # -[ diff with dv.templates 3ca8d7a10cfc7ad2307644dcac603e1f1f0feb72]-
linters <- lintr::modify_defaults(
linters
, line_length_linter = NULL # we see how long lines are when we write them
, indentation_linter = NULL
, trailing_whitespace_linter = NULL
, cyclocomp_linter = NULL # prevents trivial amount of nesting and long but straightforward functions
, object_name_linter = NULL # we have reasons to capitalize. nobody in our team CamelCase. shiny does
, object_length_linter = NULL # we don't type long var names just because
, pipe_continuation_linter = NULL # wickham being overly prescriptive
, trailing_blank_lines_linter = NULL # natural extension of trailing_whitespace_linter, present on the template
)

if(identical(Sys.getenv('CI'), "true")){
linters <- lintr::modify_defaults(
linters
, object_usage_linter = NULL # R lacks var declarations; it's easy to assign to the wrong variable by mistake
) # We only disable this lint rule on github because it fails there because
} # of a long-standing lintr bug

exclusions <- list("tests")
6 changes: 3 additions & 3 deletions DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
Package: dv.tables
Type: Package
Title: Table Modules
Version: 0.0.1
Version: 0.0.2
Authors@R: c(
person("Boehringer-Ingelheim Pharma GmbH & Co.KG", role = c("cph", "fnd")),
person(given = "Luis", family = "Moris Fernandez", role = c("aut", "cre"), email = "[email protected]")
Expand All @@ -12,7 +12,7 @@ Encoding: UTF-8
LazyData: true
Roxygen: list(markdown = TRUE)
RoxygenNote: 7.3.1
Suggests: dv.manager (>= 1.0.9.129), jsonlite, rmarkdown, testthat (>=
Suggests: dv.manager (>= 2.1.4), jsonlite, rmarkdown, testthat (>=
3.0.0), shinytest2, devtools, knitr, tibble, utils
Config/testthat/edition: 3
Config/testthat/parallel: false
Expand All @@ -22,4 +22,4 @@ Imports: shiny (>= 1.7.1),dplyr (>= 1.0.7), purrr (>= 0.3.4),
stats, pharmaverseadam
Depends: R (>= 4.0)
VignetteBuilder: knitr
Remotes: boehringer-ingelheim/[email protected].2
Remotes: boehringer-ingelheim/[email protected].4
6 changes: 6 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
# dv.tables 0.0.2

* Solves minor documentation issues.
* Removes support for data dispatchers.
* Provides early feedback for module misconfiguration.

# dv.tables 0.0.1

* hierarchical_count_table.
Loading
Loading