Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rc/v0.0.8 #13

Merged
merged 14 commits into from
Sep 18, 2024
Merged

rc/v0.0.8 #13

merged 14 commits into from
Sep 18, 2024

Conversation

zsigmas
Copy link
Contributor

@zsigmas zsigmas commented Sep 17, 2024

Fixes #12.

I've checked that:

Hotfix checklist

  • Bumped minor version number on both DESCRIPTION and NEWS.md

  • Build passes pipeline checks

  • The new changes do not affect the API

  • The new changes do not affect the documentation (including screenshots)

  • The new changes do not impact the QC report

It incorrectly assumed that all levels in sorted_x should be included in the dataframe. Counterexample, waterfall contains all participants in ADSL, at least one participant does not have a measure for that measurement and visit.
@zsigmas zsigmas self-assigned this Sep 17, 2024
@zsigmas
Copy link
Contributor Author

zsigmas commented Sep 17, 2024

depends on dv.templates#41

build depends on approval of #41 in dv.templates
@zsigmas zsigmas marked this pull request as ready for review September 18, 2024 09:19
@zsigmas zsigmas requested a review from a team as a code owner September 18, 2024 09:19
@zsigmas zsigmas merged commit d2cf18a into main Sep 18, 2024
12 checks passed
@zsigmas zsigmas deleted the rc/v0.0.8 branch September 18, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unexpected interaction with dv.explorer.parameter::mod_wfphm
2 participants