Merge pull request #3 from Boehringer-Ingelheim/2-bug-na-value-handling

Add na.rm to max call in prepare_initial_data()
Boehringer-Ingelheim · Aug 19, 2024 · 8df7105 · 8df7105
2 parents 797b234 + c6a5b96
commit 8df7105
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -1,7 +1,7 @@
 Package: dv.edish
 Type: Package
 Title: eDISH Plot Module for DILI assessment
-Version: 1.0.3
+Version: 1.0.4
 Authors@R: 
     c(
       person("Boehringer-Ingelheim Pharma GmbH & Co.KG", role = c("cph", "fnd")),

diff --git a/NEWS.md b/NEWS.md
@@ -1,3 +1,7 @@
+# dv.edish 1.0.4
+
+- The module ignores now NA values when calculating the maximum value.
+
 # dv.edish 1.0.3
 
 - Initial release of dv.edish package to GitHub.

diff --git a/R/helper_functions.R b/R/helper_functions.R
@@ -71,7 +71,7 @@ prepare_initial_data <- function(
   dataset <- Reduce(dplyr::full_join, sel_dataset_list) %>%
     dplyr::filter(.data[[lb_test_var]] %in% lb_test_choices) %>%
     dplyr::group_by(.data[[subjectid_var]], .data[[arm_var]], .data[[lb_test_var]], .data[[visit_var]]) %>%
-    dplyr::filter(.data[[lb_result_var]] == max(.data[[lb_result_var]])) %>%
+    dplyr::filter(.data[[lb_result_var]] == max(.data[[lb_result_var]], na.rm = TRUE)) %>%
     dplyr::distinct() %>%
     dplyr::ungroup()