Feature/restructure #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
wojcieko
commented
Dec 14, 2023
wojcieko
commented
- content final for 1st version
- updated vignette accordingly
Merge branch 'main' of https://github.com/Boehringer-Ingelheim/BayesianMCPMod into feature/restructure # Conflicts: # R/BMCPMod.R # R/posterior.R # man/getContrMat.Rd # man/getPosterior.Rd # man/performBayesianMCP.Rd # vignettes/analysis_normal.Rmd
- added getPriorList to vignette - fixed s3 method for modelFits predictions - added model weights to s3 print function of modelFits - changed printing behaviour for single simulation BayesianMCP - some renaming of variables & functions - added Steven Brooks as author
Merge branch 'feature/restructure' of https://github.com/Boehringer-Ingelheim/BayesianMCPMod into feature/restructure # Conflicts: # R/BMCPMod.R # R/posterior.R # man/performBayesianMCP.Rd # man/performBayesianMCPMod.Rd # vignettes/analysis_normal.Rmd
- assessDesign: added contr matrix argument, Bayesian re-estimation, improving runtime, output information, average success probability, sd as input - different model shapes of the same type can be evaluated - getPosterior can return posterior ESS - new function getESS to get ess from post_list - simulation function can take a dose-response vector - moved getPrior to vignettes
- added successRate attribute to BayesianMCP class objects - fixed a warning in print function of BayesianMCPMod that would occur if more than 1 model shape of the same type was specified
- fixed a bug in getPosteriorI regarding ESS attribute. fyi: ifelse seems to have a bug so that it only assignes only the first value of a vector - rounded ESS in assessDesign
…ngelheim/BayesianMCPMod into feature/restructure
…dividual dr vector is defined).
…ge can be build).
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #14 +/- ##
==========================================
- Coverage 55.80% 0.00% -55.81%
==========================================
Files 7 7
Lines 534 591 +57
==========================================
- Hits 298 0 -298
- Misses 236 591 +355 ☔ View full report in Codecov by Sentry. |
Xyarz
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.