adjustments to lintr and workflow adjustment

Boehringer-Ingelheim · Sep 5, 2023 · c21ad45 · c21ad45
1 parent b54481c
commit c21ad45
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml
@@ -26,6 +26,6 @@ jobs:
           needs: lint
 
       - name: Lint
-        run: tmp <- lintr::lint_package(); if (length(tmp) > 0) {print(tmp); stop("linter found problems")}
+        run: lintr::lint_package()
         shell: Rscript {0}
 
diff --git a/R/helper.R b/R/helper.R
@@ -19,9 +19,9 @@ BayesMCPMod <- function(
   sign <- 0
 
   for (j in 1:m) {
-    conttheta <- sapply(1:nrow(ancova[["est."]]), function(x) t(contMat[, j]) %*% ancova[["est."]][x, ])
-    contvar <- sapply(1:nrow(ancova[["est."]]), function(x) t(contMat[, j]^2) %*% ancova[["cov."]][x, ]^2)
-    p_ij <- sapply(1:nrow(ancova[["est."]]), function(x) stats::pnorm(conttheta[x] / sqrt(contvar[x])))
+    conttheta <- sapply(seq_len(nrow(ancova[["est."]])), function(x) t(contMat[, j]) %*% ancova[["est."]][x, ])
+    contvar <- sapply(seq_len(nrow(ancova[["est."]])), function(x) t(contMat[, j]^2) %*% ancova[["cov."]][x, ]^2)
+    p_ij <- sapply(seq_len(nrow(ancova[["est."]])), function(x) stats::pnorm(conttheta[x] / sqrt(contvar[x])))
 
 
     probs[j] <- sum(ancova[["obs."]] * p_ij)

diff --git a/R/modelling.R b/R/modelling.R
@@ -230,7 +230,7 @@ getGenAICs <- function(
   exp_values <- exp(-0.5 * avgAIC_values)
   denominator <- sum(exp_values)
 
-  for (i in 1:length(results)) {
+  for (i in seq_along(results)) {
     results[[i]]$weightedAIC <- exp_values[i] / denominator
   }