Add managed layers to audit trail #599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "dir" attribute, like on all other SCMs, should be settable by scmDefaults in default.yaml.
The "if" attribute is not evaluated and should better be rejected to prevent the user from wondering why it's not working. Even more importantly, the "dir" attribute would do active harm if used because the layer would be at an unexpected subdirectory.
No need to construct a new RecipeSet object when getting the recipes SCM status. In fact, this is actually harmful because the used layers are unknown to the new object. The status line will be wrong as soon as we support the layers status too.
When auditing recipes, the potential git checkout was not performed by Bob. Hence, no information is available if submodules shall be checked out or not. In this case, assume that potentially present submodules ought to be checked out recursively. Previously, we assumed that submodules must not be checked out which is a questionable assumption.
If the audit schema fails, it is most probably caused by an audit of a newer Bob version. Add a hint to the user that an update might help.
Now that we support managed layers, its time to add the information to the audit trail too.
Internally, the empty string is used for the main recipes. Allowing path separators in the layer name will probably also blow up. Rule out both. Some of the type checks were also missing. Make sure that the layer name is a string and that a layers entry is a dict if not already a string.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #599 +/- ##
=======================================
Coverage 88.89% 88.90%
=======================================
Files 48 48
Lines 15360 15399 +39
=======================================
+ Hits 13655 13691 +36
- Misses 1705 1708 +3 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plus a couple of other fixes...