Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

input: apply env substition to checkoutAssert #567

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

rhubert
Copy link
Contributor

@rhubert rhubert commented May 31, 2024

If variables are used to control the checkout of a package the checkoutAssert might need to be variable as well.

doc/manual/configuration.rst Show resolved Hide resolved
pym/bob/input.py Outdated Show resolved Hide resolved
pym/bob/input.py Outdated Show resolved Hide resolved
Copy link

codecov bot commented Jun 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.57%. Comparing base (277e1ae) to head (b02ac2e).
Report is 2 commits behind head on master.

Current head b02ac2e differs from pull request most recent head 0c40313

Please upload reports for the commit 0c40313 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #567      +/-   ##
==========================================
+ Coverage   79.73%   88.57%   +8.83%     
==========================================
  Files          46       46              
  Lines       14722    14725       +3     
==========================================
+ Hits        11738    13042    +1304     
+ Misses       2984     1683    -1301     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rhubert rhubert force-pushed the checkoutAssert_Env branch from e5357b4 to 830a70e Compare June 2, 2024 17:24
If variables are used to control the checkout of a package the
checkoutAssert might need to be variable as well.

Co-authored-by: Jan Klötzke <[email protected]>
@rhubert rhubert force-pushed the checkoutAssert_Env branch from 830a70e to 0c40313 Compare June 2, 2024 17:34
@jkloetzke jkloetzke merged commit 63a01b7 into BobBuildTool:master Jun 5, 2024
9 checks passed
@jkloetzke
Copy link
Member

Thanks.

@rhubert rhubert deleted the checkoutAssert_Env branch September 17, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants