Remove pre-0.16 support #557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a package is fingerprinted, the result is effectively declared to depend on the host system. How exactly is not known to Bob. Despite the actual host system, each sandbox represents a potentially different host system environment. This means that the same fingerprint script might yield different results if being executed in a sandbox, a different sandbox or the host system. This implies that packages which are fingerprinted need to be built separately for the host system and each sandbox image. With the introduction of the sandboxInvariant Bob erroneously coalesced fingerprinted packages which only differ in their host/sandbox environment. Now Bob will always use separate workspaces again for such packages. The fix will impact the calculation of the variant-id which might lead to some rebuilds. On the other hand, the build-id is not affected and existing binary artifacts will continue to be used.
As announced, support for pre-0.16 projects is removed. If no config.yaml is present, version 0.16 is implied. This might silently break old projects but the likelihood is minimal.
It never had a use case.
Remove because all pre-0.16 compatibility is removed.
Move the respective description to a new "Obsolte policies" section. Older versions ob Bob may still refer to the documentation.
Remove because all pre-0.16 compatibility is removed.
Remove because all pre-0.16 compatibility is removed.
Remove because all pre-0.16 compatibility is removed.
Remove because all pre-0.16 compatibility is removed.
Remove because all pre-0.16 compatibility is removed.
Since the removal of the sandboxInvariant policy this method is identical to getVariantId.
This parameter has no effect since the sandboxInvariant policy was removed.
This parameter has no effect since the sandboxInvariant policy was removed.
This parameter has no effect since the sandboxInvariant policy was removed.
Remove because all pre-0.16 compatibility is removed.
Remove because all pre-0.16 compatibility is removed.
Remove because all pre-0.16 compatibility is removed.
Remove because all pre-0.16 compatibility is removed.
Remove because all pre-0.16 compatibility is removed.
This support was scheduled to be removed for the 1.0 release.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #557 +/- ##
==========================================
- Coverage 88.93% 88.92% -0.01%
==========================================
Files 46 46
Lines 14803 14679 -124
==========================================
- Hits 13165 13054 -111
+ Misses 1638 1625 -13 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get rid of a good portion of legacy compatibility that makes the code hard to follow...