Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add polls #42

Merged
merged 6 commits into from
Jun 2, 2024
Merged

Add polls #42

merged 6 commits into from
Jun 2, 2024

Conversation

mifuyutsuki
Copy link
Contributor

Discord a while ago introduced polls along with its API documentation. This PR adds the typings for polls to the library. Note that I elected to name 'Layout Type' as PollLayoutType to minimize ambiguity.

Changes

Copy link
Owner

@Bluenix2 Bluenix2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I apologize for the delay with this! I am graduating any time now and have had the busiest few weeks of my life 😅

This is perfect! It makes me really happy to see that you got the hang of the codestyle pretty much immediately. Don't hesitate to reach out on Discord (bluenix2) if there was any part you found difficult. The only change I had to make was rename the file to poll (singular)!

Thanks again for the patience (not that sending a reminder would've been the wrong thing to do) ❤️

@Bluenix2 Bluenix2 merged commit 742333c into Bluenix2:main Jun 2, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants