[FEATURE] Allow payments to same lightning node where the invoice was not issued by lndhub.io

[thespielplatz]

Why (The need)

We have a custom project and lndhub.io running with the same lightning node, but lndhub does not allow payment of invoices which were not issued by lndhub (but have the same lightning node as destination) See Code.

It's our development server and we want to avoid setting up an extra node+channels. It's an effort we don't wanna do. So we thought of adding the self payment feature to lndhub.io.

What did I change?

• I added to config a custom flag: allowLightningPaymentToNode defaulting to false
• If false there is a new error message This LNDHub instance does not allow payments other then issued by LNDHub.
• if true the self payment flag is added to the lnd grpc call.
  It still can fail because of LND, but it in most cases it does work.
• Added error logging if the lnd grpc call fails

[socket-security]

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Issue	Package	Version	Note	Source
Network access	simple-update-notifier	1.1.0	Module: https Location: build/index.js	package-lock.json via [email protected]
Network access	express	4.18.2	Module: http-errors Location: lib/response.js	package-lock.json, package.json

Next steps

What is network access?

This module accesses the network.

Packages should remove all network access that isn't functionally unnecessary. Consumers should audit network access to ensure legitimate use.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore [email protected] bar@* or ignore all packages with @SocketSecurity ignore-all

• @SocketSecurity ignore [email protected]
• @SocketSecurity ignore [email protected]

[socket-security]

New and updated dependency changes detected. Learn more about Socket for GitHub ↗︎

Packages		Version	New capabilities	Transitives1	Size	Publisher
nodemon	🆕	2.0.22	network, filesystem, shell, environment	+9	388 kB	remy
express	⬆️	4.17.1...4.18.2	network	+20/-22	1.02 MB	dougwilson

Footnotes

1. https://docs.socket.dev ↩