S3 support #512
Closed
S3 support #512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
TBlueF
reviewed
Feb 23, 2024
There was a problem hiding this comment.
Thank you for the PR!
As discussed in Discord already, the Problem with it is that the aws-sdk increases BlueMap's jar size by too much.
So we will probably wait until its possible to make an addon for bluemap that adds a new storage-type and then separate this PR into such an addon :)
I still went ahead and commented all the thoughts on the code that i had found right now :)
BlueMapCommon/src/main/java/de/bluecolored/bluemap/common/config/storage/S3Config.java
Outdated
Show resolved
Hide resolved
BlueMapCore/src/main/java/de/bluecolored/bluemap/core/storage/s3/S3Storage.java
Outdated
Show resolved
Hide resolved
BlueMapCore/src/main/java/de/bluecolored/bluemap/core/storage/s3/S3Storage.java
Outdated
Show resolved
Hide resolved
BlueMapCore/src/main/java/de/bluecolored/bluemap/core/storage/s3/S3Storage.java
Outdated
Show resolved
Hide resolved
|
(force push is just a rebase) |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for using S3(and other compatible providers) as a storage backend.