Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added notebooks covering node sets and different query methods #261

Merged
merged 10 commits into from
Mar 26, 2024

Conversation

joni-herttuainen
Copy link
Contributor

@joni-herttuainen joni-herttuainen commented Feb 16, 2024

Added two notebooks:
08_nodesets_and_node_queries.ipynb:

  • node sets
  • node queries

09_edge_queries.ipynb:

  • edge queries
  • memory optimization w/ iter_connections

@codecov-commenter
Copy link

codecov-commenter commented Feb 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (d2d61c4) to head (b2d984a).

❗ Current head b2d984a differs from pull request most recent head bd5c098. Consider uploading reports for the commit bd5c098 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #261   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           33        32    -1     
  Lines         2743      2706   -37     
=========================================
- Hits          2743      2706   -37     
Flag Coverage Δ
pytest 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joni-herttuainen joni-herttuainen changed the title Added a notebook covering node sets and different query methods Added notebooks covering node sets and different query methods Feb 23, 2024
@joni-herttuainen joni-herttuainen marked this pull request as ready for review February 23, 2024 08:45
@mgeplf
Copy link
Contributor

mgeplf commented Feb 26, 2024

wow, this is really great; I think your idea of splitting the query by nodeset and query by node IDs makes sense.
Grammar and such, nothing jumped out, so after the split, LGTM.

Copy link
Contributor

@GianlucaFicarelli GianlucaFicarelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well documented 👍

README.rst Show resolved Hide resolved
doc/source/notebooks/09_edge_queries.ipynb Outdated Show resolved Hide resolved
doc/source/notebooks/08_nodesets_and_node_queries.ipynb Outdated Show resolved Hide resolved
@mgeplf
Copy link
Contributor

mgeplf commented Mar 25, 2024

Very nice!

@joni-herttuainen joni-herttuainen merged commit fb301e2 into master Mar 26, 2024
4 checks passed
@joni-herttuainen joni-herttuainen deleted the query_notebook branch March 26, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants