Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have reports use Simulation Node Sets #241

Merged
merged 11 commits into from
Nov 23, 2023
Merged

Conversation

joni-herttuainen
Copy link
Contributor

@GianlucaFicarelli : please have a look and let me know what you think of the approach.

I might've gotten tunnel-visioned here, and maybe there's a simpler approach I failed to see.

I can add more tests and explicit tests for query.resolve_nodesets but I'll rather put extra effort before you take a look and say that this is the way to go. 😅

Copy link
Contributor

@GianlucaFicarelli GianlucaFicarelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The approach looks good to me 👍

@joni-herttuainen joni-herttuainen changed the title [WIP] Have reports use Simulation Node Sets Have reports use Simulation Node Sets Nov 9, 2023
@joni-herttuainen joni-herttuainen marked this pull request as ready for review November 9, 2023 16:28
@joni-herttuainen joni-herttuainen merged commit c094e4f into master Nov 23, 2023
4 checks passed
@joni-herttuainen joni-herttuainen deleted the report_node_set branch November 23, 2023 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants