Skip to content

Commit

Permalink
remove unnecessary NodeSets._resolve_nodesets method
Browse files Browse the repository at this point in the history
  • Loading branch information
Joni Herttuainen committed Oct 23, 2023
1 parent 0f3f028 commit cd07c8a
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions bluepysnap/nodes/node_population.py
Original file line number Diff line number Diff line change
Expand Up @@ -348,9 +348,6 @@ def _check_properties(self, properties):
if unknown_props:
raise BluepySnapError(f"Unknown node properties: {sorted(unknown_props)}")

def _resolve_nodesets(self, queries, raise_missing_prop):
return query.resolve_nodesets(self._node_sets, self, queries, raise_missing_prop)

def _node_ids_by_filter(self, queries, raise_missing_prop):
"""Return node IDs if their properties match the `queries` dict.
Expand All @@ -368,7 +365,7 @@ def _node_ids_by_filter(self, queries, raise_missing_prop):
>>> { Node.X: (0, 1), Node.MTYPE: 'L1_SLAC' }]})
"""
queries = self._resolve_nodesets(queries, raise_missing_prop)
queries = query.resolve_nodesets(self._node_sets, self, queries, raise_missing_prop)
properties = query.get_properties(queries)
if raise_missing_prop:
self._check_properties(properties)
Expand Down

0 comments on commit cd07c8a

Please sign in to comment.