Remove ranks-cpus warning as can be inaccurate #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pramodk
previously approved these changes
Oct 20, 2023
1uc
force-pushed
the
1uc/remove-bad-warning
branch
from
6e02fa8 to
ae7815d
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Thanks. I will close in favor of #67 |
ferdonline
changed the title
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Logfiles from GitLab pipeline #164692 (:no_entry:) have been uploaded here! Status and direct links: |
WeinaJi
pushed a commit
that referenced
this pull request
Oct 14, 2024
The warning is misleading and causes users to run simulation with more resources than needed. Since the magic cutoff is neither a lower bound, nor an upper bound (by many orders of magnitude), we should simply not print anything. For cases where resource consumption is hard to estimate we encourage user to try the new dry-run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The warning is misleading and causes users to run simulation with more resources than needed. Since the magic cutoff is neither a lower bound, nor an upper bound (by many orders of magnitude), we should simply not print anything.
For cases where resource consumption is hard to estimate we encourage user to try the new dry-run