[BBPBGLIB-1069] Added nodes suggestions and more improvements #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
ferdonline
reviewed
Oct 19, 2023
st4rl3ss
force-pushed
the
dryrun_improvements
branch
from
f403d2b to
fafda73
Compare
This comment has been minimized.
This comment has been minimized.
ferdonline
previously approved these changes
Oct 24, 2023
st4rl3ss
changed the title
This comment has been minimized.
This comment has been minimized.
st4rl3ss
force-pushed
the
dryrun_improvements
branch
from
9b39bd9 to
006b91c
Compare
|
Logfiles from GitLab pipeline #165331 (:white_check_mark:) have been uploaded here! Status and direct links: |
ferdonline
approved these changes
Oct 30, 2023
WeinaJi
pushed a commit
that referenced
this pull request
Oct 14, 2024
## Context Introduces nodes suggestions for users. This functionality is one of the main results that should come out of the introducing of the dry run workflow. Nodes suggestion is calculated taking in mind the amount of memory present in the current machine where the code has been run. It also takes into consideration the variable amount of overhead necessary dependent on the amount of ranks used for the execution. ## Scope Most of the changes are independent of the main workflow and only touch the dry-run workflow. A prompt has been added at the end of any dry run workflow to provide a suggestion for user on how many nodes are needed in order to have a reasonable amount of memory available to run the simulation. ## Testing Since the MR just introduces a small text prompt for the user, no tests are necessary. Full dry run workflow tests will be introduced once the workflow gains a certain "maturity". ## Review * [x] PR description is complete * [x] Coding style (imports, function length, New functions, classes or files) are good * [x] Unit/Scientific test added * [x] Updated Readme, in-code, developer documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Introduces nodes suggestions for users.
This functionality is one of the main results that should come out of the introducing of the dry run workflow.
Nodes suggestion is calculated taking in mind the amount of memory present in the current machine where the code has been run. It also takes into consideration the variable amount of overhead necessary dependent on the amount of ranks used for the execution.
Scope
Most of the changes are independent of the main workflow and only touch the dry-run workflow. A prompt has been added at the end of any dry run workflow to provide a suggestion for user on how many nodes are needed in order to have a reasonable amount of memory available to run the simulation.
Testing
Since the MR just introduces a small text prompt for the user, no tests are necessary.
Full dry run workflow tests will be introduced once the workflow gains a certain "maturity".
Review