[BBPBGLIB-1184] Fix CoreNEURON reports restore functionality #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferdonline
reviewed
Nov 26, 2024
ferdonline
previously approved these changes
Nov 26, 2024
WeinaJi
reviewed
Nov 26, 2024
ferdonline
approved these changes
Nov 27, 2024
WeinaJi
approved these changes
Nov 27, 2024
- Update 'save' report.conf with new tstop instead of creating a new one
If different reports are needed during restore, this workflow needs to be adapted.
jorblancoa
force-pushed
the
jblanco/reports_saverestore
branch
from
ab2de37 to
aca92f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
During CoreNEURON restore executions in multi-circuit simulations, reports fail to generate when circuits have multiple populations with different offsets. This occurs because the GIDs are saved in the report.conf without their proper population offsets during restore, as not all circuit population offsets are calculated at this stage. As a result, CoreNEURON ignores these reports due to GID mismatch with the original save execution.
To fix this, we now reuse the 'save' report.conf file and update only its tstop value, preserving the correct GID mappings.
Review