StrEnum not working with older python versions #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorblancoa
force-pushed
the
jblanco/str_enum
branch
from
3a50971 to
8089f49
Compare
alkino
approved these changes
Feb 15, 2024
This comment has been minimized.
This comment has been minimized.
|
Logfiles from GitLab pipeline #193659 (:white_check_mark:) have been uploaded here! Status and direct links: |
ferdonline
approved these changes
Feb 15, 2024
WeinaJi
pushed a commit
that referenced
this pull request
Oct 14, 2024
## Context The StrEnum type was introduced in python 3.11, so it was failing with previous python versions in the github actions. ## Scope In this PR, StrEnum is replaced by inheriting not only from enum but also from str. ## Review * [x] PR description is complete * [x] Coding style (imports, function length, New functions, classes or files) are good * [ ] Unit/Scientific test added * [ ] Updated Readme, in-code, developer documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The StrEnum type was introduced in python 3.11, so it was failing with previous python versions in the github actions.
Scope
In this PR, StrEnum is replaced by inheriting not only from enum but also from str.
Review