[BBPBGLIB-1124] Remove hoc targets related code #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
jorblancoa
force-pushed
the
jblanco/remove_hoc_targets
branch
from
828ab74 to
69c9cb7
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
- Remove TargetManager.hoc - Remove SerializedSections.hoc
- Usage of old isCellTarget() - Usage of old .gids() - cell_manager was not present in TargetManager in multi cycle runs
jorblancoa
force-pushed
the
jblanco/remove_hoc_targets
branch
from
1f1cf1d to
a59ca62
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
WeinaJi
reviewed
Feb 8, 2024
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
WeinaJi
reviewed
Feb 9, 2024
- Add docstring - Change method name
This comment has been minimized.
This comment has been minimized.
WeinaJi
approved these changes
Feb 9, 2024
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Logfiles from GitLab pipeline #192484 (:white_check_mark:) have been uploaded here! Status and direct links: |
atemerev
pushed a commit
that referenced
this pull request
Feb 13, 2024
## Context Addresses BBPBGLIB-1124. Removes code related to hoc targets, as well as the need of using a hoc TargetManager. ## Scope Few functions were implemented in the python Targetmanager in order to remove the hoc version: getMETypes(), getPointList() and location_to_point() ## Review * [x] PR description is complete * [x] Coding style (imports, function length, New functions, classes or files) are good * [ ] Unit/Scientific test added * [ ] Updated Readme, in-code, developer documentation
atemerev
pushed a commit
that referenced
this pull request
Feb 27, 2024
## Context Addresses BBPBGLIB-1124. Removes code related to hoc targets, as well as the need of using a hoc TargetManager. ## Scope Few functions were implemented in the python Targetmanager in order to remove the hoc version: getMETypes(), getPointList() and location_to_point() ## Review * [x] PR description is complete * [x] Coding style (imports, function length, New functions, classes or files) are good * [ ] Unit/Scientific test added * [ ] Updated Readme, in-code, developer documentation
WeinaJi
pushed a commit
that referenced
this pull request
Oct 14, 2024
## Context Addresses BBPBGLIB-1124. Removes code related to hoc targets, as well as the need of using a hoc TargetManager. ## Scope Few functions were implemented in the python Targetmanager in order to remove the hoc version: getMETypes(), getPointList() and location_to_point() ## Review * [x] PR description is complete * [x] Coding style (imports, function length, New functions, classes or files) are good * [ ] Unit/Scientific test added * [ ] Updated Readme, in-code, developer documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Addresses BBPBGLIB-1124.
Removes code related to hoc targets, as well as the need of using a hoc TargetManager.
Scope
Few functions were implemented in the python Targetmanager in order to remove the hoc version:
getMETypes(), getPointList() and location_to_point()
Review