Skip to content

Commit

Permalink
Address comments
Browse files Browse the repository at this point in the history
 - Add docstring
 - Change method name
  • Loading branch information
jorblancoa committed Feb 9, 2024
1 parent e0d823b commit a472ba0
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 3 deletions.
4 changes: 2 additions & 2 deletions neurodamus/connection_manager.py
Original file line number Diff line number Diff line change
Expand Up @@ -603,7 +603,7 @@ def _add_synapses(self, cur_conn, syns_params, syn_type_restrict=None, base_id=0
cur_conn.add_synapses(self._target_manager, syns_params, base_id)

# -
def get_updated_population_offsets(self):
def get_population_offsets(self):
sgid_offset = self._src_cell_manager.local_nodes.offset
tgid_offset = self._cell_manager.local_nodes.offset
return sgid_offset, tgid_offset
Expand Down Expand Up @@ -819,7 +819,7 @@ def get_target_connections(self, src_target_name,
if src_target and src_target.is_void() or dst_target.is_void():
return

_, tgid_offset = self.get_updated_population_offsets()
_, tgid_offset = self.get_population_offsets()
populations: List[ConnectionSet] = (conn_population,) if conn_population is not None \
else self._populations.values()

Expand Down
5 changes: 4 additions & 1 deletion neurodamus/target_manager.py
Original file line number Diff line number Diff line change
Expand Up @@ -595,7 +595,10 @@ def generate_subtargets(self, n_parts):


class SerializedSections:
"""Serializes the sections of a cell for easier random access."""
""" Serializes the sections of a cell for easier random access.
Note that this is possible because the v field in the section has been assigned
an integer corresponding to the target index as read from the morphology file.
"""
def __init__(self, cell):
self.num_sections = int(cell.nSecAll)
# Initialize list to store SectionRef objects
Expand Down

0 comments on commit a472ba0

Please sign in to comment.