-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added threads tests #54
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The endpoints should rather be tested with the dependency override mechanism of FastAPI. We had these tests in neuroagent previously, and in theory they had little links to langchain so few of them will need modifications. Thank you for handling this though !
My thinking was that unit tests should only test the function and mock anything else When you don't mock the depended functions and let the function have side effects such as writing to a DB, that is usually called an integration test. |
No description provided.