Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "units" attribute even in empty timestamps dataset #45

Merged
merged 2 commits into from
Aug 13, 2024
Merged

Add "units" attribute even in empty timestamps dataset #45

merged 2 commits into from
Aug 13, 2024

Conversation

jorblancoa
Copy link
Collaborator

@jorblancoa jorblancoa commented Aug 7, 2024 •
edited
Loading

Needed to accommodate changes introduced in libsonata PR #363:
BlueBrain/libsonata#363

@coveralls
Copy link

Pull Request Test Coverage Report for Build 10287888701

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.03%) to 86.416%
Totals Coverage Status
Change from base Build 9269869569: -0.03%
Covered Lines: 757
Relevant Lines: 876
💛 - Coveralls

@jorblancoa jorblancoa merged commit 92f55ac into master Aug 13, 2024
4 checks passed
@jorblancoa jorblancoa deleted the jblanco/units_attribute branch August 13, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1uc 1uc 1uc approved these changes

@ferdonline ferdonline ferdonline approved these changes

@alkino alkino Awaiting requested review from alkino

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jorblancoa @coveralls @ferdonline @1uc