This repository has been archived by the owner on Mar 20, 2023. It is now read-only.
New allocators with sensible names and more #872
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
October 12, 2022 16:40
work in progress - some tests fail
Reintroduce MemoryManaged class such that things can be moved slowly to new allocators
added 2 commits
October 24, 2022 14:47
UnifiedMemManaged and HostMemManaged now have overridden new and delete operators so that these operations happen correctly behind the scenes. NrnThread now inherits from UnifiedMemManaged. Also fixed a bunch of minor issues
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
(WIP)
Fixes #806
How to test this?
check out nrn, change to this branch in coreneuron submodule, build and test as per nrn repo instructions
Test System
Use certain branches in CI pipelines.
CI_BRANCHES:NEURON_BRANCH=master,NMODL_BRANCH=master,SPACK_BRANCH=develop