Skip to content

Commit

Permalink
[mobile] More README updates
Browse files Browse the repository at this point in the history
Quite sure that "Possible Deprecated Development Notes" is no longer applicable. I remember modifying [shared] a couple days ago and VSCode Intellisense recognizing it seamlessly.
  • Loading branch information
jsubloom committed Sep 13, 2023
1 parent 1dbef9e commit 900876f
Showing 1 changed file with 2 additions and 7 deletions.
9 changes: 2 additions & 7 deletions packages/mobile/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ yarn
yarn start
```

Any changes you make in [web] or [mobile] should be hot reloaded.
Any changes you make in [shared], [web], or [mobile] should be hot reloaded.
Note: if you change the file structure in [mobile], hot reloading might not work, restart the development server if necessary.

## Build loop for phone
Expand All @@ -84,7 +84,7 @@ Note: if you change the file structure in [mobile], hot reloading might not work

- Go to a bloom-player repo at the desired revision.
- yarn build-dev. (This builds an unminified version)
- Use "yarn link", or copy the contents of bloom-player's dist/bloomPlayer.js to this repo's assets/web-dist/bloomPlayer/bloomPlayerMin.jsAsset
- Use "yarn link [...]", or copy the contents of bloom-player's dist/bloomPlayer.js to this repo's assets/web-dist/bloomPlayer/bloomPlayerMin.jsAsset
- Reload the app
- Edit this file (bloomPlayerMin.jsAsset) as needed for debugging purposes.
- Reload the app every time this file changes.
Expand Down Expand Up @@ -147,11 +147,6 @@ If you're on a Windows machine, it'll let you enter the keystore dialog and then

For iOS, if you're on a windows machine, you can start a cloud build (`yarn eas build -platform ios --profile {desiredProfile}`), fill out the dialogs, and then when it starts uploading your build to the cloud, you can cancel it. It'll still save the credential information and now your non-interactive builds on the Github action runner will be able to pick up the information.

### Possibly Deprecated Development Notes

After updating something in the "shared" package, you often need to manually Restart Typescript Server (use Ctrl+Shift+P in Visual Studio) before it gets the updates, unfortunately. I'm not sure why it has trouble picking it up.
I guess it may have something to do with using a local package. (Typescript path alias picked up the updates almost instantly)

### Tunnel

This will make it so that your phone and your dev machine don't have to be on the same network. In fact, a colleague on the other side of the country can test your local changes this way!
Expand Down

0 comments on commit 900876f

Please sign in to comment.