Add platform

BloomBooks · Aug 31, 2023 · 101c638 · 101c638
1 parent c04ea44
commit 101c638
Show file tree

Hide file tree

Showing 3 changed files with 26 additions and 7 deletions.
diff --git a/.github/workflows/build-full.yml b/.github/workflows/build-full.yml
@@ -1,7 +1,16 @@
-name: build-full
+name: Cloud Build
 on:
     workflow_dispatch:
         inputs:
+            platform:
+                type: choice
+                description: "Which mobile platforms to build"
+                required: true
+                default: "all"
+                options:
+                    - android
+                    - ios
+                    - all
             releaseStage:
                 type: choice
                 description: "type of release"
@@ -79,8 +88,7 @@ jobs:
 
             # IF interested in trying local build: https://github.com/suiet/suiet/blob/63b50e4ba225b294af1018f3f98b9666738837c7/.github/workflows/build-app.yml#L9
             - name: 3A) [mobile] EAS Cloud Build
-              # run: eas build --platform all --profile  ${{ github.event.inputs.releaseStage }} --non-interactive --no-wait
-              run: eas build --platform android --profile  ${{ github.event.inputs.releaseStage }} --non-interactive --no-wait
+              run: eas build --platform  ${{ github.event.inputs.platform }} --profile  ${{ github.event.inputs.releaseStage }} --non-interactive --no-wait
               working-directory: packages/mobile/
 
             # - name: 3B) [electron] Install dependencies

diff --git a/.github/workflows/build-local.yml b/.github/workflows/build-local.yml
@@ -1,7 +1,16 @@
-name: Build on Github (${{ github.event.inputs.releaseStage }})
+name: Local Build
 on:
     workflow_dispatch:
         inputs:
+            platform:
+                type: choice
+                description: "Which mobile platforms to build"
+                required: true
+                default: "all"
+                options:
+                    - android
+                    - ios
+                    - all
             releaseStage:
                 type: choice
                 description: "type of release"
@@ -14,7 +23,7 @@ on:
 
 jobs:
     build-local-job:
-        name: Build application binaries (${{ github.event.inputs.releaseStage }})
+        name: Build application binaries
         runs-on: ubuntu-latest
         #runs-on: macos-latest
 
@@ -80,8 +89,7 @@ jobs:
 
             # Inspired by: https://github.com/suiet/suiet/blob/63b50e4ba225b294af1018f3f98b9666738837c7/.github/workflows/build-app.yml#L9
             - name: 3A) [mobile] EAS Cloud Build
-              # run: eas build --platform all --profile  ${{ github.event.inputs.releaseStage }} --non-interactive --no-wait
-              run: eas build --local --platform android --profile  ${{ github.event.inputs.releaseStage }} --non-interactive --no-wait
+              run: eas build --platform  ${{ github.event.inputs.platform }} --profile  ${{ github.event.inputs.releaseStage }} --non-interactive --no-wait
               working-directory: packages/mobile/
 
             - name: Print Folder Structure

diff --git a/packages/mobile/TODO.md b/packages/mobile/TODO.md
@@ -1,2 +1,5 @@
 Change the status bar color
 AppBar needs some padding - amount TBD
+
+Android builds fail in beta and release - Looks like https://github.com/expo/expo/issues/23265. Does this workaround work? https://github.com/expo/expo/issues/23265#issuecomment-1662709655
+Well, or if you just publish the packages to the NPM repository, that would solve it for the release case. For local builds, you can continue using yarn link, and we have a viable workaround in local development and alpha mode.