Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Papua-Literacy summary to have correct image URL #5969

Open
wants to merge 1 commit into
base: Version5.5
Choose a base branch
from

Conversation

JohnThomson
Copy link
Contributor

@JohnThomson JohnThomson commented Jul 3, 2023

This change is Reviewable

Copy link
Contributor

@gmartin7 gmartin7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to have been fixed by removing the other url components and just keeping the file name, like most of our brandings. Should this PR be closed?

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @JohnThomson)

Copy link
Contributor

@gmartin7 gmartin7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @JohnThomson)


src/content/branding/Papua-Literacy/summary.htm line 3 at r1 (raw file):

<div class="vertical">
    <div>Organization: Papua Literacy</div>
    <img src="/bloom/branding/Papua-Literacy/back.png" />

This was fixed in 5.4. (This PR targets 5.5.) Suggest closing...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants