Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Testnet4 Network #91

Open
wants to merge 1 commit into
base: new-index
Choose a base branch
from

Conversation

BinChengZhao
Copy link

@BinChengZhao BinChengZhao commented Jul 4, 2024

Support for testnet4 Block Data Indexing Based on Latest rust-bitcoin

During the development phase, I deployed a testnet4 full node to test this feature, and everything worked as expected.

Changes:

  • Implementation of testnet4 Support: This feature is based on the latest rust-bitcoin. Although the relevant PR has not yet been merged into bitcoin Core, and thus rust-bitcoin has not been merged either, the code is stable and functional.

  • API Updates: Updated several API calls that were flagged as deprecated by rust-bitcoin.

  • New Cursor for Block parse: Implemented a new cursor for block parse due to the removal of some necessary APIs in the updated rust-bitcoin.

Ask for advice:

After implementing these changes, everything functions correctly with the default feature set. However, when enabling the liquid feature, issues arise because it relies on elements, which is currently incompatible with the latest rust-bitcoin. I would appreciate any insights or suggestions on how to resolve this compatibility issue.


Thank you for your time and assistance.

@RCasatta
Copy link
Collaborator

After implementing these changes, everything functions correctly with the default feature set. However, when enabling the liquid feature, issues arise because it relies on elements, which is currently incompatible with the latest rust-bitcoin. I would appreciate any insights or suggestions on how to resolve this compatibility issue.

We need a rust-elements version using the same rust-bitcoin, I'll probably make a branch for it in the next days unless someone is quicker

@BinChengZhao
Copy link
Author

After implementing these changes, everything functions correctly with the default feature set. However, when enabling the liquid feature, issues arise because it relies on elements, which is currently incompatible with the latest rust-bitcoin. I would appreciate any insights or suggestions on how to resolve this compatibility issue.

We need a rust-elements version using the same rust-bitcoin, I'll probably make a branch for it in the next days unless someone is quicker

Thank you very much for your response, I will also pay attention to cooperation

@RCasatta
Copy link
Collaborator

FYI rust-elements has been released if you want to update this MR everything should work (TM)

@BinChengZhao
Copy link
Author

According to the upstream dependency update, I re-adjusted the code so that all the compiled branches passed, including liquid.

The only sorry is that I did not have time to test today, and I may need to respond after I have some free time to complete the test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants