Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration tests #104

Merged
merged 2 commits into from
Sep 11, 2024
Merged

Conversation

RCasatta
Copy link
Collaborator

With this by default cargo test will not print any logs

by doing RUST_LOG=debug cargo test instead, there is the same logging than before this MR

to instead have logs like before use `RUST_LOG=debug cargo test`
@RCasatta RCasatta requested a review from shesek August 23, 2024 08:27
Copy link
Collaborator

@shesek shesek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine making this change, but just curious - what's the rational behind it?

@RCasatta
Copy link
Collaborator Author

RCasatta commented Sep 11, 2024

The rational is that by default cargo test should not print anything but the test results summary.

For example running on master you have:

running 2 tests
test rest::tests::test_parse_query_param ... ok
test rest::tests::test_parse_value_param ... ok

... a lot of log lines ...

test test_rest ... ok

test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 2.45s


So to see test_parse_query_param result you have to scroll up, and for some refactor those these stop to be executed you risk to miss it

@RCasatta RCasatta merged commit 16321d4 into Blockstream:new-index Sep 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants