Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modular #212

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Modular #212

wants to merge 3 commits into from

Conversation

SeanMcOwen
Copy link
Contributor

No description provided.

@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

danlessa
danlessa requested changes Apr 23, 2024
View reviewed changes
Copy link
Member

@danlessa danlessa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should make sure that the definitions at params.py does match with the AztecModelParams on types.py, as the latter is the source of truth of what are the system parameters. Also, this allows for type checking through mypy

aztec_gddt/params.py
safety_factor_commit_bond=0.0,
safety_factor_reveal_content=0.0,
safety_factor_rollup_proof=0.0,
past_gas_weight_fraction=0.9,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure to add the new parameters into the AztecModelParams definition at types.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danlessa danlessa danlessa requested changes

@jackhack00 jackhack00 Awaiting requested review from jackhack00

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SeanMcOwen @danlessa