Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement rayon #17

Merged
merged 9 commits into from
Oct 18, 2024
Merged

Implement rayon #17

merged 9 commits into from
Oct 18, 2024

Conversation

ahqsoftwares
Copy link
Contributor

This PR adds rayon support alongside crossbeam

Blakeinstein
Blakeinstein reviewed Oct 16, 2024
View reviewed changes
Copy link
Owner

@Blakeinstein Blakeinstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, will test the code a bit later. Can you also include tests/examples as well for the rayon flag. Also was wondering if we should better naming conventions for the feature flags.

.vscode/settings.json Outdated Show resolved Hide resolved
Cargo.toml Show resolved Hide resolved
@Blakeinstein
Copy link
Owner

Please run cargo clippy and cargo fmt!

Blakeinstein
Blakeinstein reviewed Oct 18, 2024
View reviewed changes
Cargo.toml Outdated Show resolved Hide resolved
@ahqsoftwares
Copy link
Contributor Author

CI!!!

@Blakeinstein Blakeinstein merged commit 514f2c9 into Blakeinstein:master Oct 18, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Blakeinstein Blakeinstein Blakeinstein approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahqsoftwares @Blakeinstein