-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update tutorial to demonstrate image reading #59
Conversation
606c4a6
to
0fc0175
Compare
0fc0175
to
5b1f5e5
Compare
|
||
@classmethod | ||
def from_zarr(cls, node: zarr.Group) -> Self: | ||
def _from_spec(cls, spec: _ImageSpec) -> Self: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a bit of a hack for testing
I need to fix the tutorial, but would be good to hear your thoughts on this @d-v-b, in particular:
|
There's a better version of this at #64 |
This:
I'm not 100% sure this is the best way to go in terms of what our "top level" object is and looks like, but I'm wary about sub-classing from another library as we'll lose the flexibility of doing what we want. Very open to other suggestions/ideas though, ideally with modifications to the tutorial to show how they would work as public API.