Allow building against external zstd library (for non-CMake builds) #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
past-due
approved these changes
Apr 16, 2023
|
I would also like to see this (or something similar to this) merged. @richgel999 |
|
so do I, for the Debian package! for the impatient: http://sid.ethz.ch/debian/basis-universal/ |
|
@akien-mga Looks like the latest commits to master have yielded some small conflicts, but hopefully @richgel999 might be willing to take a look at this once resolved? |
…ns (mostly in non CMake builds). In our internal repository, we have our own version of zstdlib and introducing extra copy is both undesirable and potentially dangerous (due to ODR violations). Co-authored-by: Rémi Verschelde <[email protected]>
akien-mga
force-pushed
the
zstd-external
branch
from
b4a0fa2 to
6394a27
Compare
|
Rebased on latest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebase of @ondys' #228 with one missed include changed too.
Supersedes #228. (This PR can be closed if #228 is updated with the
transcoderchange.)We have the same need in the Godot project, also with a non-CMake build (relevant build file for SCons: https://github.com/godotengine/godot/blob/master/modules/basis_universal/SCsub).
CMake users may also want to have an easy way to use their own zstd implementation, but for this PR I followed @ondys' steps to do the minimal changes needed by existing downstream projects which shouldn't break the workflow for the main app.