Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/handle all promises #335

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Feat/handle all promises #335

wants to merge 3 commits into from

Conversation

maximeBAY
Copy link
Collaborator

@maximeBAY maximeBAY commented Dec 19, 2024 •
edited
Loading

  • The project passes automated tests locally (build, linting, etc.).
  • You updated the project's documentation with new changes.
  • You've linked any issue this PR closes
  • You reviewed your own PR and made sure there's no test/debug code or any obvious mistakes.

Make sure that the code wasn't copied from elsewhere (check one):

  • This is your own original code
  • [] You have made sure that we have permission to use the copied code and that we follow its licensing

Add catch to unhandled promises and display error messages for related errors

@maximeBAY maximeBAY linked an issue Dec 19, 2024 that may be closed by this pull request
All promises should be handled #331
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Samuel-Therrien-Beslogic Samuel-Therrien-Beslogic Awaiting requested review from Samuel-Therrien-Beslogic Samuel-Therrien-Beslogic is a code owner

@theo-auffeuvre theo-auffeuvre Awaiting requested review from theo-auffeuvre theo-auffeuvre is a code owner

@BesOlivierBouchard BesOlivierBouchard Awaiting requested review from BesOlivierBouchard BesOlivierBouchard is a code owner

@NicolasDontigny NicolasDontigny Awaiting requested review from NicolasDontigny NicolasDontigny is a code owner

@gab-gil gab-gil Awaiting requested review from gab-gil gab-gil is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

All promises should be handled
1 participant
@maximeBAY