Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: change register form to react hook form #332

Merged
merged 5 commits into from
Dec 17, 2024

Conversation

gab-gil
Copy link
Collaborator

@gab-gil gab-gil commented Dec 16, 2024

  • The project passes automated tests locally (build, linting, etc.).
  • You updated the project's documentation with new changes.
  • You've linked any issue this PR closes
  • You reviewed your own PR and made sure there's no test/debug code or any obvious mistakes.

Make sure that the code wasn't copied from elsewhere (check one):

  • This is your own original code
  • You have made sure that we have permission to use the copied code and that we follow its licensing

Close #319

Copy link
Contributor

@Samuel-Therrien-Beslogic Samuel-Therrien-Beslogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few details. But I like what this does to the code. Much cleaner and less verbose
image

@@ -0,0 +1 @@
**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This project doesn't concern itself with prettier, it's already marked as a non-recommended extensions in the .vscode/extensions config, you can disable per-workspace with
image

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not using vscode. This is normally the recommended solution for prettier users. If you want I can add it to the gitignore so that it isn't commited

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we have to add more acknowledgements of prettier despite not using it, I'd rather have the file that disables it instead of adding it to .gitignore and still having issues from other contributors running it automatically.

But let's do that in another PR.

I'm also curious which editor you're using and if it supports per-project/workspace configurations.

canopeum_backend/pyproject.toml Outdated Show resolved Hide resolved
canopeum_frontend/src/utils/validators.ts Outdated Show resolved Hide resolved
canopeum_frontend/src/pages/Register.tsx Show resolved Hide resolved
canopeum_frontend/src/pages/Register.tsx Outdated Show resolved Hide resolved
canopeum_frontend/src/pages/Register.tsx Outdated Show resolved Hide resolved
@Samuel-Therrien-Beslogic Samuel-Therrien-Beslogic merged commit fab14cc into main Dec 17, 2024
2 checks passed
@Samuel-Therrien-Beslogic Samuel-Therrien-Beslogic deleted the refactor/register-form branch December 17, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Password fields don't accept special characters
3 participants