Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update development steps in readme #328

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Update development steps in readme #328

wants to merge 3 commits into from

Conversation

Samuel-Therrien-Beslogic
Copy link
Contributor

@Samuel-Therrien-Beslogic Samuel-Therrien-Beslogic commented Dec 12, 2024 •
edited
Loading

  • The project passes automated tests locally (build, linting, etc.).
  • You updated the project's documentation with new changes.
  • You've linked any issue this PR closes
  • You reviewed your own PR and made sure there's no test/debug code or any obvious mistakes.

Make sure that the code wasn't copied from elsewhere (check one):

  • This is your own original code
  • You have made sure that we have permission to use the copied code and that we follow its licensing

@Samuel-Therrien-Beslogic Samuel-Therrien-Beslogic changed the title Update README.md Add note about docker compose up Dec 12, 2024
Samuel-Therrien-Beslogic
Samuel-Therrien-Beslogic commented Dec 12, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
@Samuel-Therrien-Beslogic Samuel-Therrien-Beslogic changed the title Add note about docker compose up Update development steps in readme Dec 12, 2024
Samuel-Therrien-Beslogic
Samuel-Therrien-Beslogic commented Dec 12, 2024
View reviewed changes
README.md
Comment on lines +35 to +40
On Linux you must instal the mysql dev binaries to be able to build the `mysqlclient` python distribution.

- Debian / Ubuntu: `apt-get install default-libmysqlclient-dev`
- Red Hat / CentOS: `yum install mysql-devel`
- Arch: `pacman -S mysql`

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just as additional information, I recently learned there's a proposal to solve this need: https://peps.python.org/pep-0725/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theo-auffeuvre theo-auffeuvre Awaiting requested review from theo-auffeuvre theo-auffeuvre is a code owner

@BesOlivierBouchard BesOlivierBouchard Awaiting requested review from BesOlivierBouchard BesOlivierBouchard is a code owner

@NicolasDontigny NicolasDontigny Awaiting requested review from NicolasDontigny NicolasDontigny is a code owner

@gab-gil gab-gil Awaiting requested review from gab-gil gab-gil is a code owner

@maximeBAY maximeBAY Awaiting requested review from maximeBAY maximeBAY is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Samuel-Therrien-Beslogic